fix: Fix DeviceFeatures so that it can be serialized and deserialized properly #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properly. Adds tests for the desired output.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes serialization and deserialization issues in the DeviceFeatures class by improving the naming convention handling for complex variable names. The fix addresses two specific challenges: (1) the complex naming patterns used in device feature variables (e.g., handling numbers and acronyms like "CES2022"), and (2) the unique typing of boolean field dictionaries in DeviceFeatures.
Key changes:
- Enhanced
_decamelizefunction to properly handle numbers and acronyms in variable names - Renamed
is_ces2022_supportedtois_ces_2022_supportedfor consistent naming - Added comprehensive test coverage for serialization/deserialization of device features and similar structures
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_supported_features.py | Adds serialization/deserialization test for DeviceFeatures |
| tests/test_containers.py | Adds test for boolean features serialization and parametrized tests for camelize/decamelize functions |
| roborock/device_features.py | Renames field from is_ces2022_supported to is_ces_2022_supported |
| roborock/data/containers.py | Updates _decamelize function with improved regex patterns and adds class type checking |
| SUPPORTED_FEATURES.md | Updates documentation to reflect renamed field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the desired output, then update the algorithm to make the tests path (AI assisted).
This needs additional support because (1) the naming of variables for device features are more complex than other fields and (2) the typing of a dict of boolean fields is unique to DeviceFeatures.
This adds a few variations of tests for different forms of coverage from:
Required to fix home-assistant/core#157663